Continue on AppInsights setup errors to simplify local development - #131
Conversation
|
Tested Azure-Samples/todo-nodejs-mongo and Azure-Samples/todo-csharp-cosmos-sql locally and remotely, which should cover all changes. Python template already has a guard in place: |
Matt Ellis (ellismg)
left a comment
Matt Ellis (ellismg)
left a comment
There was a problem hiding this comment.
LGTM - I put a note about where I believe we source the key from for the SPA frontend.
Wallace Breza (wbreza)
left a comment
Wallace Breza (wbreza)
left a comment
There was a problem hiding this comment.
Thanks for the contributions. One minor comments otherwise looks good to go :)
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: todo-csharp-cosmos-sqlRemote: azure-samplesBranch: pr/131You can initialize this project with: azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/131View Changes | Compare Changes Project: todo-csharp-mongoRemote: azure-samplesBranch: pr/131You can initialize this project with: azd init -t Azure-Samples/todo-csharp-mongo -b pr/131View Changes | Compare Changes Project: todo-csharp-sqlRemote: azure-samplesBranch: pr/131You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/131View Changes | Compare Changes Project: todo-nodejs-mongo-acaRemote: azure-samplesBranch: pr/131You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/131View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samplesBranch: pr/131You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/131View Changes | Compare Changes Project: todo-nodejs-mongoRemote: azure-samplesBranch: pr/131You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/131View Changes | Compare Changes Project: todo-python-mongo-acaRemote: azure-samplesBranch: pr/131You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-aca -b pr/131View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samplesBranch: pr/131You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/131View Changes | Compare Changes Project: todo-python-mongoRemote: azure-samplesBranch: pr/131You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo -b pr/131View Changes | Compare Changes |
5 participants
Fixes #105
With this change if Application Insights setup throws (e.g. when running apps locally), we log the error but let an application work.